GoSecure / pyrdp

RDP monster-in-the-middle (mitm) and library for Python with the ability to watch connections live or after the fact
https://www.gosecure.net/blog/2020/10/20/announcing-pyrdp-1/
GNU General Public License v3.0
1.5k stars 242 forks source link

Added a catch-all for NTSTATUS for error codes we don't care about #471

Closed luciaprime54 closed 4 months ago

luciaprime54 commented 8 months ago

Some Clients can return other Error codes that we can safely ignore, such as the MacOS Windows RDP Client when transferring multiple files.

Rather than hardcode 1000s of possible Status codes Just handle the ones we need to and create a catch-all for the ones we don't care about so we don't throw an exception and crash unnecessarily.

Unfortunately I don't have the specific error code I saw on Mac (it was a while ago, and it wasn't every time), but this solution would hopefully also help if other clients do the same thing.