formigarafa
commented
1 year ago Hello, there @Tostino.
I have made a change on my project on what I believe would be the equivalent of this line on this project: https://github.com/GoSimpleLLC/nbvcxz/blob/main/src/main/java/me/gosimple/nbvcxz/matching/DictionaryMatcher.java#L271
Something along the lines below.
public List<Match> match(final Configuration configuration, final String password)
{
final List<Match> matches = new ArrayList<>();
// Create all possible sub-sequences of the password
for (int start = 0; start < password.length(); start++)
{
for (int end = start + 1; end <= search_end(start, password.length(), dictionary_identifier); end++)
{
final String split_password = password.substring(start, end);
...I believe on your case, if you follow this direction there may be a few more things to adjust because I noticed you only iterate over the dictionaries further inside the nesting of for loops so you don't have an dictionary identifier at that point. But even if you just limit to the size of the largest word among all dictionaries the performance would improve.
Tostino
Combine the output of concecutive bruteforce matches prior to returning the result. This is ugly as can be right now with each letter going into a bruteforce match.
Note - this will change the scoring for these, which isn't quite right currently, as we don't properly guess the cardinality of the total bruteforce section of the password.
Example: