search

GoTeamEpsilon / angular-to-react-redux

Angular to React/Redux, a Guide for Angular v1 Experts Looking to Learn React/Redux
MIT License
107 stars 12 forks source link

implement contact feature in redux port #62

Closed MatthewVita closed 7 years ago

ghost commented 7 years ago
  1. So in your mind is components/Patient.js the same as demographics/basic from the Angular app?
  2. If so, this would mean that alongside your component, I should create another dumb-presentational component for the emergency contacts.
  3. I probably will have to use a different container, although maybe we can use the same container if there is more overlap than we expect.
  4. I will post more questions later, but let's see what questions I have that still remain after further studying :)
ghost commented 7 years ago

  1. The next question I think will be how to handle forms. This is the most popular form library with 5,000 stars: https://github.com/erikras/redux-form

  2. However, in the repo we forked from they don't even have a Redux Form library in their package.json so that might be unnecessary. I used that library a while ago but it was not the easiest thing.

  3. I think the having a form with just simple click handlers that fire off action creators would be fine and easier, however if you want some more of that advanced stuff like form error messages that only display after a field has been touched at least once and such that would be the way to go.

Sorry to outsource the decision to you all but you can make the best judgment about what would be helpful for Angular people :)

MatthewVita commented 7 years ago

This is all done... I based my work off of your branch. Great base for me!

Here's a bug that came out of this impl though: https://github.com/GoTeamEpsilon/angular-to-react-redux/issues/92

I've asked @ShaneChesnutt to work on it :)