search

GoUpNumber / gun

The Go Up Number Wallet
BSD Zero Clause License
49 stars 9 forks source link

Secret randomness refactor #82

Closed LLFourn closed 2 years ago

LLFourn commented 2 years ago
  1. Store the randomness in the database instead
  2. Make it optional
  3. Remove support for old configs for simplicity
  4. and require re-initialisation to upgrade wallet

I thought it wasn't yet worth it to introduce a proper upgrade function. Now that v0.6 no longer simply involves changes to the config I trashed the backwards compatible config reading. You need to gun init seedwords --from-existing to upgrade

nickfarrow commented 2 years ago

Yeah agree config migration can easily be manual via init seed, and that into_v1 was an easy place to forget things.

So after these changes, users can only use betting protocol if they init with some bip85_entropy (seed or provided with coldcard, but not descriptor). We could use this import_entropy flag with descriptors also?

LLFourn commented 2 years ago

@nickfarrow in the fixups branch I'm making possible to set this after init using gun config ....