search

GoXLR-on-Linux / goxlr-on-linux

Documentation and scripts to make the GoXLR and GoXLR Mini useful on Linux.
142 stars 8 forks source link

Fix ALSA hardware selection failing in some instances #18

Closed lm41 closed 3 years ago

lm41 commented 3 years ago

Deleted the ", 0" after "hw:GoXLR"

lm41 commented 3 years ago

Only merge if this work on Ubuntu. (Tested on Manjaro)

RobinVanCauter commented 3 years ago

For completeness sake: someone reported (on Discord) the GoXLR is not found anymore when removing the ,0 on Manjaro. We should investigate further before merging this.

I will set up a couple of VM's with different distributions so I can easily test against the different distro's.

If we have one extra case of Manjaro working fine, it is probably something specific with his setup and we can merge this, but for now I'd put this on hold until we know more.

lm41 commented 3 years ago

If we have one extra case of Manjaro working fine, it is probably something specific with his setup and we can merge this, but for now I'd put this on hold until we know more.

As I said, on my Manjaro machine it works fine.

VirtualJunky commented 3 years ago

If it seems to work on some distros and not others, perhaps there could be extra versions of configure_goxlr.sh and configure_goxlr_mini.sh that don't include the zero. Then during install it could run the appropriate configure script, pause and ask the user for a Y/N if there is errors, and if so to run the following jack_control stop, jack_control exit, pulseaudio --kill then the other version, which ever works is the one entered in .profile.

The downside obviously being every change will need to be made in 4 files now, instead of 2 but opens it up to more people.

lm41 commented 3 years ago

[...], which ever works is the one entered in .profile.

The downside obviously being every change will need to be made in 4 files now, instead of 2 but opens it up to more people.

We are trying to get this work with systemd. So there are 4 more files. But I think that this check would be a good idea. What do you think @T-Grave ?

VirtualJunky commented 3 years ago

Thought about this some more and remembered the install script reboots at the end, I wasn't sure what this was for since JACK2 and PulseAudio both start automatically when installed and any config changes can be applied by simply pulseaudio --kill which made me question why it rebooted in the first place. In any case the above idea won't work if the install script reboots, or at best it needs to run pulseaudio --kill first which makes the reboot unneeded. I opened #20 to note this and so people can test on other distros.

RobinVanCauter commented 3 years ago

Having 4 different files seems like a headache, I think it makes more sense to have only 1 file and dynamically get the identifiers. Everything we cannot determine dynamically goes into a config file instead and we read from there.

RobinVanCauter commented 3 years ago

Up until now we only have one instance of someone having an issue without the 0, maybe we should just merge this see if more people have issues and try and determine why that is the case when it pops up :) We can always post "add ,0" as a temp workaround for the rare cases where it's an issue

lm41 commented 3 years ago

Closes #15

VirtualJunky commented 3 years ago

I was also the only person with the issue having the 0 though so it seems like a rare issue either way. Hard to see which way is less rare to be the default then can config the option for the other, you know? Will leave it up to you guys on which one you want default, on the config I'm working on I've already included a toggle to fix the issue anywho, will work in either direction.