GoXLR-on-Linux / goxlr-ui

A User Interface that hooks with the GoXLR Daemon
MIT License
21 stars 15 forks source link

Update the Visualiser to use 'Raw' Encoder Values (Util #d6ecd993) #32

Closed FrostyCoolSlug closed 7 months ago

FrostyCoolSlug commented 7 months ago

I've added a new field to the Encoders in the Utility that reports 'exact' values of the encoders, with the goal to do away with the need to try and calculate the values (which can often result in small rounding errors). The values that can come from the GoXLR are as follows:

In my testing, the visualisation display is now 100% accurate with the GoXLR, the reason for this PR is to make sure the changes aren't going to completely explode something else :)

FrostyCoolSlug commented 7 months ago

I made the initial change to computeEncoderRotation to use raw_encoder, but had to switch it back because the spin speed changed for the worst, I can look into fixing that or leave that to you (you'll require a utility checkout of dev-1.0.6), but it's mostly visual, so I'm not overly fussed releasing as-is.