search

GoXLR-on-Linux / goxlr-utility

An unofficial GoXLR App replacement for Linux, Windows and MacOS
MIT License
636 stars 36 forks source link

Unmute doesn't take fader position into account (mini) #103

Closed fenarinarsa closed 11 months ago

fenarinarsa commented 12 months ago

When unmuting a channel, the channel's volume reverts to the value it was when muting, even if the fader was moved when the channel was muted.

Correct behavior should be to unmute to the fader's position volume.

Note: this behavior was also fixed in the official app

Version: 0.12.4 Windows, GoXLR mini

FrostyCoolSlug commented 12 months ago

Thanks for the report, when I did my testing they hadn't fixed this yet, so the mini behaviour was the same as the full size behaviour which is how it was implemented.

Testing on the latest version, you're right, it doesn't mess with the volumes anymore when the mute button is hit on a fader, I'll look into updating the util to match.

FrostyCoolSlug commented 12 months ago

The behaviour has been changed with bde544e and will come with the next release.

fenarinarsa commented 11 months ago

Thanks!! I'm looking forward to it, because I stopped using the official client. GoXLR utility has a big advantage over it, it doesn't crash when Windows goes out of sleep mode :)

FrostyCoolSlug commented 11 months ago

I've got a test build at https://github.com/GoXLR-on-Linux/goxlr-utility/suites/14344137562/artifacts/807561591 - could you give it a download and test for me please? Just to make sure it's all working right :)

fenarinarsa commented 11 months ago

I've got a test build at https://github.com/GoXLR-on-Linux/goxlr-utility/suites/14344137562/artifacts/807561591 - could you give it a download and test for me please? Just to make sure it's all working right :)

Didn't test it thoroughly but it seems to work perfectly :)

FrostyCoolSlug commented 11 months ago

This fix is now released in 0.12.5, so closing the issue :)