search

GoXLR-on-Linux / goxlr-utility

An unofficial GoXLR App replacement for Linux, Windows and MacOS
MIT License
670 stars 37 forks source link

Sampler should better understand what directory samples are being picked from #118

Open AlienXAXS opened 1 year ago

AlienXAXS commented 1 year ago

As GoXLR Utility will search for a filename when detecting what sample to play, if your sample directory contains multiple of the same file name it will always pick the first found.

For example: Creating audio.mp3 in two different folders will always pick the first one found, even if you do not select the first file in the web interface.

EG: data/samples/person1/audio.mp3 data/samples/person2/audio.mp3

person1/audio.mp3 will always be played, even if person2/audio.mp3 is picked, or if both are a part of a single sample button.

Is it instead possible to have the Web UI also send over some sort of breadcrumb file path to ensure the correct mp3 is played?

I found this bug when I noticed that a few of my samples are not being played, I have a few voice recordings of my friends all organised into folders with the same file name on a single sample button randomised... While a fix for this could be "make the file names different" I do not feel this is user friendly.

AlienXAXS commented 1 year ago

Looks like this bug exists (but in reverse) on the official app too, it seems to always play the last file found.

Not sure if you're able to fix this, or perhaps put some sort of warning that multiple files of the same name were found, up to you bud!

parzival-space commented 1 year ago

I can't remember exactly, but I think I heard that this is because the profile files only save the name of the sample file and not the complete path. The utility does exactly the same as the original software to maintain compatibility.

AlienXAXS commented 1 year ago

I can't remember exactly, but I think I heard that this is because the profile files only save the name of the sample file and not the complete path. The utility does exactly the same as the original software to maintain compatibility.

Hi bud, Yeah I just looked at the profile files and you're 100% right, they do indeed only save the file name... Such a strange design decision from them initially imho!

I've since renamed all of my same-named files so they play correctly, but happy to wait for Frosty to see if he wants to do anything special with this before closing.

FrostyCoolSlug commented 1 year ago

While I'm trying to keep profile compatibility, there's not much I can do about this for now, although it might be worth opening an issue on the UI side, and I'll look into putting a warning in.