GoXLR-on-Linux / goxlr-utility

An unofficial GoXLR App replacement for Linux, Windows and MacOS
MIT License
636 stars 36 forks source link

Recorded and manually added samples play at different volumes. #119

Closed ghost closed 6 months ago

ghost commented 11 months ago

I'm unsure if this is a bug or not but any files I manually add to the sampler play at a much higher volume level than samples I've recorded. I noticed this while trying to move certain sounds to a single button but whenever I manually add a sample it sounds way too loud even if it's something I recorded with the sampler.

Here's an example video I recorded. https://www.youtube.com/watch?v=mJVILS2DiQI

FrostyCoolSlug commented 10 months ago

This is the same behaviour as the official app, Samples which are added go through an EBU R 128 pass to normalize them to 'broadcast' level, however, to avoid the additional overhead or calculating the levels 'live', samples which are being recorded do not. If you remove the recording, and re-add it, in both the official App and the Util, it'll be normalised in the same way.

In the future, I'll be looking into options to configure / change this behaviour somewhat, although I've not created a list of options for it yet. For now though, this is working as intended (even if a little obscure).

ghost commented 10 months ago

Cheers for the insight! It's a bit weird and annoying to deal with but I'm glad to hear that you'll be looking into things though.

FrostyCoolSlug commented 7 months ago

So I've made some changes to how the utility handles Samples for the upcoming v1.0.1 release.

Samples recorded by holding a button will now receive the same gain calculations as a sample which is manually added, so quieter recordings will be boosted up to correct level to match other Samples

In addition, I've added what can only be described as a Volume 'Override' slider to Samples, which allows for manual adjustments if a user feels the calculations are off.

Could you grab the windows articaft at the bottom of this build, which contains the changes and give them a test please?

Thanks

FrostyCoolSlug commented 6 months ago

Closing as Fixed.