GoXLR-on-Linux / goxlr-utility

An unofficial GoXLR App replacement for Linux, Windows and MacOS
MIT License
635 stars 36 forks source link

[Bug] Systray Icon Does Not Persist After a Windows Explorer Crash/Restart #124

Closed anthonybaldwin closed 10 months ago

anthonybaldwin commented 10 months ago

OS: Windows 11 22H2

Expected: Systray icon persists after a Windows Explorer crash/restart Actual: Systray icon is not present after a Windows Explorer crash/restart


Steps to recreate: (Pre-req: GoXLR Utility running w/ systray icon present)

  1. Open Task Manager and search for Windows Explorer, then right click and restart
  2. 🐛 See the icon is no longer present in systray
  3. In Task Manager again search for goxlr-daemon.exe, then right click and end the task
  4. Re-open GoXLR Utility
  5. 🩹 See the icon is present again in systray

Seems solvable quickly searching:

I'll look into submitting a PR myself if/when I have more time, but figured I'd simply report for now.


Now to report the same thing to Corsair for iCUE...

FrostyCoolSlug commented 10 months ago

sobs quietly

Looks like I'll need a bit of restructuring of the tray code, although shouldn't be too difficult, I'll try and get this fixed soon.

FrostyCoolSlug commented 10 months ago

This should be fixed now, can you give this test build a try please (check the artifacts at the bottom):

https://github.com/GoXLR-on-Linux/goxlr-utility/actions/runs/6075499743

anthonybaldwin commented 10 months ago

This should be fixed now, can you give this test build a try please (check the artifacts at the bottom):

https://github.com/GoXLR-on-Linux/goxlr-utility/actions/runs/6075499743

Looks good to me. Thank you!