GoXLR-on-Linux / goxlr-utility

An unofficial GoXLR App replacement for Linux, Windows and MacOS
MIT License
669 stars 37 forks source link

Update Package Version and Edition Strings #136

Closed xieta closed 10 months ago

xieta commented 10 months ago
xieta commented 10 months ago

Hi Frosty,

I added these version numbers so I can tell whether I'm running the production code or the dev branch.
I haven't looked into how I can show the commit ID in the build version on the daemon's startup.

Best Regards, -Xi

FrostyCoolSlug commented 10 months ago

Ok, so not incrementing the version number until release is a conscious decision. If it's incremented here, and a bugfix / improvement goes in before the final release, you will not be notified of it in the update checker (the checker looks at the current version and compares it against the latest tag). This caused some problems with the 1.0 release because I had prematurely bumped the version, then handed out test builds. Users weren't prompted of the full 1.0 release.

Also, is there any reason you're changing the rust edition?

xieta commented 10 months ago

It turns out bumping the edition was an ignorant suggestion on my part. I thought the edition label was another descriptor for the package version because I didn't know any better.

Kindly disregard the PR. I was just looking for a good way to know which binary is running when I launch the daemon.