search

GoXLR-on-Linux / goxlr-utility

An unofficial GoXLR App replacement for Linux, Windows and MacOS
MIT License
636 stars 36 forks source link

Improve doc for web UI #19

Closed thomas-louvigne closed 1 year ago

thomas-louvigne commented 2 years ago

I just add the link and an image on the readme.

FrostyCoolSlug commented 2 years ago

I'd like to put a hold on this MR, and revisit it a little later on, the UI included with the Daemon is an early preview at best and hasn't been through a proper release cycle yet (it was added after alpha1), there have been a huge number of changes and tweaks since then. It would make more sense to add this once the UI is complete (and we've made the repo public).

thomas-louvigne commented 2 years ago

i have written that's feature is in beta. Perhaps we can write more clearly it not fully functional now ?

I send this MR, because i forgot the port of UI.

And, I think that for security reasons, it could be interesting to indicate that a web port opens when you launch the daemon

lm41 commented 2 years ago

And, I think that for security reasons, it could be interesting to indicate that a web port opens when you launch the daemon

I think the posibility to start the web server will be optional in the future.

FrostyCoolSlug commented 2 years ago

You're right, we should mention that by default a web server is loaded and should expand on the reasoning (for serving the configuration tool), although with that being said, I think we should exclude a screenshot of the webui for the time being.

FrostyCoolSlug commented 1 year ago

I'm going to close this for now, I've rewritten a chunk of the README prior to the 0.2.0 release, which includes details about the WebUI, as well as instructions for turning it off. Going forward, I'm going to be using feature branches rather than pushing directly to main, which should prevent situations like this happening!