search

GoXLR-on-Linux / goxlr-utility

An unofficial GoXLR App replacement for Linux, Windows and MacOS
MIT License
636 stars 36 forks source link

Allow public bind address from web settings #64

Closed timmo001 closed 1 year ago

timmo001 commented 1 year ago

I'm creating an integration with this application for Home Assistant, and have found that I needed to add --http-bind-address 0.0.0.0 to the daemon shortcut to allow remote connections to the API/Websocket.

This isnt the simplest setup and would like to see this in the GUI/Webapp, so others are able to easily allow remote connections

FrostyCoolSlug commented 1 year ago

I've been meaning to do this for a while, when the daemon was originally written it was never intended to be accessed outside of localhost, but that changed over time via requests.. The WebUI config has continued to grow since, and would definitely benefit from having a UI panel at this point to allow more fine grained configuration.

I'll look into this for the 0.12 release, while I finish tidying up functionality.

Dreamtrailtv commented 1 year ago

I think that for many streamers with a separate streaming setup it can be useful to control the GoXLR with their main setup.

@timmo001: can you post your integration i wanted to do the same and got stuck at the same point :)

timmo001 commented 1 year ago

I think that for many streamers with a separate streaming setup it can be useful to control the GoXLR with their main setup.

@timmo001: can you post your integration i wanted to do the same and got stuck at the same point :)

Will do when its ready to use. Current stage is experimenting and setting up a basic integration

Dreamtrailtv commented 1 year ago

I think that for many streamers with a separate streaming setup it can be useful to control the GoXLR with their main setup. @timmo001: can you post your integration i wanted to do the same and got stuck at the same point :)

Will do when its ready to use. Current stage is experimenting and setting up a basic integration

I can test with you if you have something working

timmo001 commented 1 year ago

Here's the custom integration repository.

FrostyCoolSlug commented 1 year ago

This is implemented in d9873dd6, and is labelled in the settings as 'Allow UI network access' (that may be renamed before release), if checked the UI will bind to all interfaces (0.0.0.0) on startup.

For legacy purposes, if --http-bind-address is in use, it will override that setting (and allow more fine-grained settings for those who want it).

timmo001 commented 1 year ago

Perfect! I'll look forward to the next release 👍