GoXLR-on-Linux / goxlr-utility

An unofficial GoXLR App replacement for Linux, Windows and MacOS
MIT License
636 stars 36 forks source link

Effects: Multi-Tap support for Presets to update Echo Tempo #74

Open FrostyCoolSlug opened 1 year ago

FrostyCoolSlug commented 1 year ago

So according to the manual, and seemingly in the official app, repeatedly tapping on a effect preset button will adjust the echo tempo value.

From some basic testing and investigation, the app seems to create an array of size 4 which is initially filled with the current value. A BPM value is calculated between the last two presses of the button (based on I would assume time) which replaces an entry in the array and a new BPM is calculated as an average.

Find a way to smartly implement this :D

a2hsh commented 1 year ago

Also, if I may add:

  1. When the tempo calculation process starts, stop announcing the preset name on button press to SRS; as they might confuse users who want to sync the tempo with the music they're hearing.
  2. When the tempo calculation process stops, and after the timer passes the 1 second mark and gets canceled, announce the current tempo to SRS, and go back to the default behavior, which is announcing the preset's name on button click.

Thank you!