search

Gobluebro / Elden-Ring-Checklist

A checklist for you to complete as you go through Elden Ring.
https://gobluebro.github.io/Elden-Ring-Checklist/
MIT License
72 stars 26 forks source link

Missing Limgrave Site of Grace #61

Closed Hautemeal closed 4 months ago

Hautemeal commented 4 months ago

Deathtouched Catacombs Site of Grace is missing.

Thanks for this btw!

Hautemeal commented 4 months ago

Just found it under Stormhill. I wasn't expecting it to be split into a subregion.

Gobluebro commented 4 months ago

Yeah no worries. I believe the graces specifically are ordered by how they appear in game. That's why it's under the sub region.

Thanks the effort of reaching out to help make this project better

Hautemeal commented 4 months ago

That makes sense. I also noticed that Mistwood is a subregion, but doesn’t have its own section like others. But at least the categories are all sorted by in-game distance to each other, so it’s not a big deal once you figure that out. I’m on my first NG+ run and finding this guide super helpful. Cheers!On Jun 26, 2024, at 9:10 AM, Griffin Strayer @.***> wrote: Yeah no worries. I believe the graces specifically are ordered by how they appear in game. That's why it's under the sub region. Thanks the effort of reaching out to help make this project better

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

Gobluebro commented 4 months ago

You might be into something here. I'll check what my in game says and compare it to what's written down here

Hautemeal commented 4 months ago

It seems like a very minor inconsistency since it would only be two or three sites of grace. And it’s debatable whether any of those are actually in the Mistwoods, or if they’re just outskirts of it, but they are all down there on the same plane. For consistency’s sake, it might make sense to have them be under a Mistwood category, but I think I may also be of the opinion that too many categories with 1-3 locations adds unnecessary clutter, but there are definitely pros and cons to each method. One refines the searchability and the other adds hierarchy clutter. Just my two cents as I’m using it for the first time. But, as I’m using it, I do find that the subregion method makes sense and is helpful, even if I’ve never thought to break it down that way. Anyway, thanks again for the response and actively working on this! On Jun 26, 2024, at 10:26 AM, Griffin Strayer @.***> wrote: Reopened #61.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

Gobluebro commented 4 months ago

I think originally it was modeled off of what the wiki would say about the grace and they had their own classifications of what region each grace was in.

But I think for completionist's sake it should probably be exactly how the game shows it when you open the menu. That way you can immediately know whether or not if you are missing graces.

Hautemeal commented 4 months ago

Ah! Now THAT’S a great idea. On Jun 26, 2024, at 2:21 PM, Griffin Strayer @.***> wrote: I think originally it was modeled off of what the wiki would say about the grace and they had their own classifications of what region each grace was in. But I think for completionist's sake it should probably be exactly how the game shows it when you open the menu. That way you can immediately know whether or not if you are missing graces.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

Gobluebro commented 4 months ago

image Are you seeing something different in your game? I had to go quickly grab the grace in my ng+ to check but I'm seeing Stormhill

Hautemeal commented 4 months ago

Same, I’m very early into my first NG+, but, yeah, that all matches what I have at the moment (plus Limgrave Divine Tower).On Jun 26, 2024, at 2:43 PM, Griffin Strayer @.***> wrote: image.png (view on web) Are you seeing something different in your game? I had to go quickly grab the grace in my ng+ to check but I'm seeing Stormhill

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

Gobluebro commented 4 months ago

Awesome glad we checked that

Hautemeal commented 4 months ago

Same. Thanks for being a cool nerd!

On Wed, Jun 26, 2024 at 2:51 PM Griffin Strayer @.***> wrote:

Awesome glad we checked that

— Reply to this email directly, view it on GitHub https://github.com/Gobluebro/Elden-Ring-Checklist/issues/61#issuecomment-2192684013, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWSZJMIVCC3W6TWW5MBY2WDZJMZU7AVCNFSM6AAAAABJ6GPOBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGY4DIMBRGM . You are receiving this because you modified the open/close state.Message ID: @.***>