search

Goby56 / wakes

Minecraft mod that adds splashes and wakes while traveling on water
GNU General Public License v3.0
77 stars 13 forks source link

Ticking Entity Crash when re-entering a world 1.21.1 Fabric #108

Open Yoni664 opened 2 months ago

Yoni664 commented 2 months ago

Describe the bug When re-entering a world the game crashes due to ticking entity error, I used Neruina to track the crashes and it points to a problem with Wakes and Puzzleslib. The crash only occurs when you want to re-enter the world, what I mean is that when you start minecraft for the first time you can enter the world and play normally, only when you exit to the main menu and re-enter the world is when the crash occurs. From what I noticed the crash is generated by entities that are in water when loading the world, even items that are floating in the water generate the crash.

Expected behavior Re-entering the world without problems

To Reproduce Open minecraft Create or join a world Exit the world to the main menu Re-enter the world

Screenshots image Image from the chat message of Neruina

Hardware and OS If the bug is related to rendering, please provide at least which graphics card and OS you are using.

Versions

Additional information Link to Neruina Auto Report [puzzleslib, wakes] (25 sept 2024 - 17:47:43): https://github.com/Bawnorton/NeruinaAutoReports/issues/203 Crash Log: crash-2024-09-25_17.41.09-server.txt

Yoni664 commented 2 months ago

Another crash report from Neruina. This time there were so many entities that a CTD simply occurred: crash-2024-09-25_18.22.10-server.txt

Yoni664 commented 2 months ago

Using Wakes 0.2.5 on 1.21.1 seems to work without any problems.

AlienXtream commented 2 months ago

getting this on 1.20.1 too so its likely a core issue. seems to be related to something about the wake sim ticking. here's the crash from my version

crash-2024-09-28_21.22.11-server.txt

bachleon commented 1 month ago

same ticking entity for me with the same re-loading behaviour. I can enter the game from the launcher once with no issues whatsoever, but quitting to menu then re-loading a world crashes every time. I manually removed mods 1 at a time with no change until I removed wakes, which has fixed the issue entirely.

crash-2024-10-06_08.45.03-server.txt