search

Goby56 / wakes

Minecraft mod that adds splashes and wakes while traveling on water
GNU General Public License v3.0
77 stars 13 forks source link

Velocity Waves/Foam #48

Open SaltSouls opened 10 months ago

SaltSouls commented 10 months ago

So, while I like the introduction of the waves and the foam particles(I do believe they could use a little work), the waves behavior is a bit wonky. For one, the way they look in a boat is really strange. You would imaging they would be more towards the sides of the boat, but currently they are clipping into the boat itself. It doesn't even look like they are coming from the water. Also, there seems to be an issue with their, and the wakes rendering, where they appear full bright even in dark areas.

As for the foam, I think this is an easy improvement. just make it less transparent, increase the particle quantity, make them stationary when they spawn, and increase their lifetime a little. I don't feel like they need to have any movement given that they should be the particles left behind as the entity moves through the water.

2024-01-20_09 29 31 2024-01-20_09 31 26

PS. I should have also mentioned that the velocity waves lag behind the boat movement, so if you turn super fast, the waves will slowly move back towards the front of the boat instead of staying at the front.

Goby56 commented 10 months ago

I fully agree on the particle part. They seem a bit out of place at the moment and I will definitely fix it some time in the future. For now though I need to address some bugs that just some people experience (and it seems as though you are one of them too). Wakes appear infront of some objects (the boat in your case), see issue #46. And the foamy white parts of the wakes take up too much space (it should look something like this): preview-0 Then it also seems that the bug with fully lit wakes is back.

Personally I have none of these issues with the latest version and I know that it also works for people I've recently played with. Just in case, make sure to fully reset your configs of the mod (i.e remove the whole config file "wakes.json" and let the mod create a new one).

Because just some people experience similar issues I think the cause of the bugs lies with what hardware and possibly OS the user has. To make a complete picture of why these bugs may occur, could you provide what OS and graphics card you are using? In addition to this it would also be helpful if you cycled through the shader programs found in the debug settings and tell me if any of them makes it look better. (images are welcome)

SaltSouls commented 10 months ago

I'm running arch Linux on an AMD Radeon 6800xt. The last version of the mod didn't have any problems with rendering, aside from wakes getting darker when looked at from above.

As far as the shader that looks best, the general setting looks the best as it makes sure the wakes don't darken when looking at them from a top down view. Though as you can also see, it makes everything full bright, and makes the white sections take up way too much space. I will try deleting my config to see if that fixes any of the problems, and then get back to you.

SaltSouls commented 10 months ago

I can confirm that even after allowing the config to regenerate, I'm still getting these bugs. The thing that was fixed was the overly white wakes. Those are now back to normal after the config was regenerated.

After more testing, ENTITY_TRANSLUCENT_CULL looks the best in the sense that it doesn't run into the full bright issue, but it does have the problem of looking at the wakes/waves from different angles will result in their shading changing. When looked at from a top down view, they appear a lot darker. Though this method does properly render them from underwater, making the wakes look darker when viewed from under water. I feel like if you could find a nice in between of GENERAL and ENTITY_TRANSLUCENT_CULL then the rendering, as far as lighting, will likely be resolved.

Topdown: 2024-01-22_09 37 39 Forward: 2024-01-22_09 37 45 Underwater: 2024-01-22_09 37 50

Goby56 commented 10 months ago

Is this with fancy or fabulous graphic settings? You see, I could only get wakes under water working with fabulous.

SaltSouls commented 10 months ago

Is this with fancy or fabulous graphic settings? You see, I could only get wakes under water working with fabulous.

I'm using Embeddium, so maybe? I don't know if Embeddium just defaults to fabulous graphics, or if this is a result of the render layer issue with wakes right now.