search

Goby56 / wakes

Minecraft mod that adds splashes and wakes while traveling on water
GNU General Public License v3.0
69 stars 14 forks source link

Dark/black water wakes when on some shader types #51

Open Daniel99j2 opened 7 months ago

Daniel99j2 commented 7 months ago

Describe the bug Dark/black water wakes when on some shader types

Expected behavior The wakes are coloured like in the 1.20.2 0.2.2 version

To Reproduce Load the game Create some wakes

Screenshots 2024-01-22_09 27 06

Hardware and OS Windows 11 AMD Radeon Graphics

Versions

Additional information Seems like https://github.com/Goby56/wakes/issues/14 but still on 0.2.3 Video Settings Graphics do not matter

In log: 09:42:13.844 net.minecraft.class_5944 Render thread Shader wakes:translucent_no_light_direction could not find uniform named Light0_Direction in the specified shader program. 09:42:13.845 net.minecraft.class_5944 Render thread Shader wakes:translucent_no_light_direction could not find uniform named Light1_Direction in the specified shader program.

When changing the Debug Shader to GENERAL or ENTITY_TRANSLUCENT_CULL, the issue is fixed however all others are black.

Daniel99j2 commented 7 months ago

The main problem is that by default, the shader is set to AUTO, which is broken

Goby56 commented 7 months ago

When changing the Debug Shader to GENERAL or ENTITY_TRANSLUCENT_CULL, the issue is fixed however all others are black.

Do wake textures react to light with these shader programs? That is, do they appear fully bright in caves and at night?

XanderCreates commented 7 months ago

When changing the Debug Shader to GENERAL or ENTITY_TRANSLUCENT_CULL, the issue is fixed however all others are black.

Do wake textures react to light with these shader programs? That is, do they appear fully bright in caves and at night?

I am not the same person, but this is the exact same issue im encountering, and yes, wakes are also fully bright for me, but only when it is set to GENERAL, but entity_translucent_cull seems to work fine

HaipaDev commented 7 months ago

Yeah the General shader seems to work best I am not using Iris shaders, but Nvidium probably messes with all that And the bigger issue im encountering is splashes being visible through blocks and entities - literal xray And its only happening on newest version (0.2.3), 0.2.0 works no problem

CrawlingPlanet commented 7 months ago

i dont use any shaders and i have the same problem

Daniel99j2 commented 7 months ago

@CrawlingPlanet Not Like Iris or optifine shaders, we are talking about the mod rendering shaders

theodorebje commented 5 months ago

Just wanted to chime in and say that I managed to get this working by installing Indium.

Goby56 commented 5 months ago

Could anyone else try the mod with Indium and see if it fixes it?

Jsuispasici commented 4 months ago

I'm having the same issue with an optimisation modpack with iris installed but no shader enabled

Jsuispasici commented 4 months ago

Could anyone else try the mod with Indium and see if it fixes it?

it doesn't

Ourriasta commented 1 month ago

hi , i have issue with complementary unbound that create a second sun each time i have a light source in hand or black waves when using a light source with reimagined.

I'm using sodium and indium

HaipaDev commented 1 month ago

hi , i have issue with complementary unbound that create a second sun each time i have a light source in hand or black waves when using a light source with reimagined.

I'm using sodium and indium

you know you can upload photos right?