Goby56 / wakes

Minecraft mod that adds splashes and wakes while traveling on water
GNU General Public License v3.0
75 stars 13 forks source link

Crash when rendering wakes #65

Closed Daniel99j2 closed 6 months ago

Daniel99j2 commented 6 months ago

Describe the bug Whenever my client renders a wake, it crashes

Expected behavior It should not crash

To Reproduce

  1. Join world
  2. Create wake
  3. Crash

Screenshots N/A

Hardware and OS Windows 11

Versions

Additional information Note that in 0.2.2 it only froze, and I had to stop it, so crash is from 0.2.2 and log is from 0.2.3 Logs - https://mclo.gs/7Vzxs3d#L1515 Crash - https://mclo.gs/ZP2WAsN

Daniel99j2 commented 6 months ago

Config: { "effectSpawningRules": { "mobs": "SIMULATION_AND_PLANES", "items": "SIMULATION_AND_PLANES", "other_players": "SIMULATION_AND_PLANES", "boat": "SIMULATION_AND_PLANES", "player": "SIMULATION_AND_PLANES" }, "wakesInRunningWater": true, "wavePropagationFactor": 0.949999988079071, "waveDecayFactor": 0.5, "initialStrength": 20, "paddleStrength": 100, "splashStrength": 100, "spawnParticles": false, "disableMod": false, "floodFillDistance": 3, "use9PointStencil": true, "ticksBeforeFill": 2, "drawDebugBoxes": false, "renderType": "GENERAL", "wakeResolution": "SIXTEEN", "wakeOpacity": 1.0, "useWaterBlending": true, "blendFunc": "DEFAULT", "srcFactor": "SRC_ALPHA", "dstFactor": "ONE_MINUS_SRC_ALPHA", "colorIntervals": [ { "color": "TRANSPARENT", "lower": -50, "upper": -45 }, { "color": "DARK_GRAY", "lower": -45, "upper": -35 }, { "color": "GRAY", "lower": -35, "upper": -30 }, { "color": "LIGHT_GRAY", "lower": -30, "upper": -15 }, { "color": "TRANSPARENT", "lower": -15, "upper": 2 }, { "color": "LIGHT_GRAY", "lower": 2, "upper": 10 }, { "color": "WHITE", "lower": 10, "upper": 20 }, { "color": "LIGHT_GRAY", "lower": 20, "upper": 40 }, { "color": "GRAY", "lower": 40, "upper": 50 } ], "splashPlaneWidth": 3.0, "splashPlaneHeight": 1.5, "splashPlaneDepth": 2.0, "splashPlaneResolution": 5, "maxSplashPlaneVelocity": 0.5, "splashPlaneScale": 1.0, "splashPlaneOffset": 0.0 }

Daniel99j2 commented 6 months ago

Looks like GENERAL shader is not valid anymore (Not an option)