Goby56 / wakes

Minecraft mod that adds splashes and wakes while traveling on water
GNU General Public License v3.0
63 stars 13 forks source link

[1.20.1] Wakes don't form during swimming animation on surface of water #85

Open Reshy opened 1 month ago

Reshy commented 1 month ago

Describe the bug Wakes don't occur when near the surface in the "swimming" animation.

Expected behavior Wakes should occur from swimming near surface.

To Reproduce Enter the swimming animation in water and angle towards the surface. Even touching the surface of the water fails to produce wakes.

Screenshots image image

What it should look like (Creative Flying at water surface): image

Hardware and OS Windows 10

Versions

Goby56 commented 1 month ago

When in swimming mode the player's hitbox becomes just a small box. I would imagine that hitbox is fully submerged in your case which means that no wakes will be generated.

If you would like it would be appreciated if you turned on hitboxes and send some more images.

Reshy commented 1 month ago

With additional testing it appears that you need to be sticking about .25 blocks above the water line in order to produce wakes.

Max Swim Height: 2024-07-12_14 40 55 2024-07-12_14 41 06 2024-07-12_14 41 08

Minimum Height to produce Wakes: 2024-07-12_14 42 51 2024-07-12_14 42 03

Examples that fail to reach the minimum: 2024-07-12_14 43 04 2024-07-12_14 42 43 2024-07-12_14 41 28