search

Goby56 / wakes

Minecraft mod that adds splashes and wakes while traveling on water
GNU General Public License v3.0
75 stars 13 forks source link

Wakes have an extremely high performance impact for me #95

Open Nostalgion opened 2 months ago

Nostalgion commented 2 months ago

After noticing lots of lag looking in certain directions, I realized oceans seem to lag a lot. I'll go from 300fps to 40, looking in land direction and ocean direction respectively

The mod was working fine previously or so i thought, but recently i've noticed heavy performance degradation and spark is pointing to this mod

https://spark.lucko.me/qYxqMVoAfr

Hardware and OS Windows 10 Pro, RTX 2070 Super, 5800X3D, 32GB RAM

Versions 1.20.1, wakes versions 0.2.1 through 0.2.4 replicate this.

The mod is running through connector on a forge instance but I believe the spark report shows its not necessarily a symptom of that, but I may be wrong.

AnonymousUserDA commented 2 months ago

I'm having this problem as well, except for me its basically unplayable since i'm on a low end device

Goby56 commented 1 month ago

Does the latest version fix it for you?

owohail commented 1 month ago

i'm also having the same issue on a 3080ti. going from 250~300fps to <=75 when installing wakes.

since no one else seems to have tried, i decided to build from current main branch. when using jdk 21 and gradlew, it gives a crash on boot. here's the crash log for 1.21.1 from that attempt, it also crashes on 1.21 with the same error.

Goby56 commented 1 month ago

Does version 0.3.0 give you this crash and poor performance?

owohail commented 1 month ago

0.3.0 gives me the performance problems mentioned, yes

the crash is only present in the version i built from the repo's current main branch commit as of writing, and is not present on public pre-built downloads. i tried to build it since your reply (and the last commit) was last week, while 0.3.0 was from 3 weeks ago, figured maybe you made a change only on the repo.