Closed nknotts closed 8 years ago
Thanks, this is good.
Both of those warnings are evaluating the correct operator, but you might as well make them go away. Could you add the extra parentheses, check that this compiles on your setup and commit to your branch and I will complete the merge.
I think it should be:
static const uint64 HALF = (static_cast<uint64>(1) << (Model::CODE_VALUE_BITS-1));
and
(('^' > double_[push_back(phoenix::ref(base_dim_powers), _1)]) | eps[push_back(phoenix::ref(base_dim_powers), 1)])),
Compilation on OSX 10.11.1/clang 7 is now warning free.
I had to remove the
using phoenix::ref
statement to fix compilation on OSX 10.11 w/clang 7.I also added a few common entries to gitignore to keep my build clean.
.DS_Store is a file that OS X likes to add to every directory. *.swp are temporary files created by vim while editing CMakeLists.txt.user is the project file used by qtcreator (my IDE of choice)
Also, clang gave me a few warnings.
These can probably be safely ignored but I just wanted to make sure the code is doing what you intend.