GobySoft / dccl

Dynamic Compact Control Language
Other
17 stars 13 forks source link

Changed bitset operator overloads from bitwise operators to logical assignments. #118

Closed psmskelton closed 1 year ago

psmskelton commented 1 year ago

Changed the Bitset &=, |=, and ^= operator overloads to logical assignments instead of bitwise operators to fix scan warnings.

Since C++11, these are guaranteed to be equivalent operations, except LHS is only evaluated once instead of twice.

psmskelton commented 1 year ago

Interestingly, I cannot reproduce the scan problems with lua-protobuf on my end.