search

GobySoft / dccl

Dynamic Compact Control Language
Other
17 stars 13 forks source link

Cmake updates #15

Closed nknotts closed 7 years ago

nknotts commented 7 years ago

I made two changes to CMakeLists.txt

  1. I set dccl_BUILD_DIR to ${CMAKE_BINARY_DIR} to allow for paths other than build
  2. I made symlinks optional. I defaulted them to on for backwards compatibility
tsaubergine commented 7 years ago

Looks good, except can you change the text on ADD_SYMLINKS (copy/paste error)

nknotts commented 7 years ago

I made the change before the merge

tsaubergine commented 7 years ago

Yeah I realized that. Thanks.

On Jun 22, 2017 17:48, "Nathan Knotts" notifications@github.com wrote:

I made the change before the merge

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/GobySoft/dccl/pull/15#issuecomment-310437830, or mute the thread https://github.com/notifications/unsubscribe-auth/AAssdBAA8BNHfaouIMl7dd3i_v4PGhL6ks5sGprbgaJpZM4OCeuT .