search

GobySoft / dccl

Dynamic Compact Control Language
Other
17 stars 13 forks source link

python: version in setup.py doesn't match top-level version #48

Closed kguilbert closed 5 years ago

kguilbert commented 5 years ago

Currently __version__ in python/setup.py is set to "3.0.8". It looks like this was intended to match the library version but it's not being bumped.

tsaubergine commented 5 years ago

@chrismurf Is there a way you can pull this from the CMakeLists.txt (DCCL_VERSION_MAJOR, etc.) or add a new version.txt that both the CMakeLists.txt and python reference?

kguilbert commented 5 years ago

@tsaubergine I just noticed that the 3.0.10 tag is one commit before DCCL_VERSION_PATCH was set to 10, so the 3.0.10 release still shows a version of 3.0.9.

tsaubergine commented 5 years ago

@tsaubergine I just noticed that the 3.0.10 tag is one commit before DCCL_VERSION_PATCH was set to 10, so the 3.0.10 release still shows a version of 3.0.9.

This is fixed now. Thanks

chrismurf commented 5 years ago

Right now, the python build happens in-tree, not in the build folder, and isn't coordinated by CMakeLists. Making CMakeLists do the build is not something I am good at, though @kguilbert has done it a couple of times. I am more tempted by the version.txt approach, unless you (or @kguilbert) feel strongly?

kguilbert commented 5 years ago

Using a version.txt sounds like the least intrusive change that will preserve the in-tree python builds. I've done it with a "setup.py.in" which is generated by CMake, but then you lose the ability to run setup.py without first building with cmake.