cmake: use install TARGETS in order to properly strip RPATHs

GobySoft / dccl

Dynamic Compact Control Language

Other

17 stars 13 forks source link

cmake: use install TARGETS in order to properly strip RPATHs #64

Closed russkel closed 4 years ago

russkel commented 4 years ago

fixes #63. The install directory and permissions are set correctly by default.

russkel commented 4 years ago

The failing is due to this:

Since CMake 3.13 install(TARGETS) can work even with targets created in other directories.

If I added an install statement in each app's CMakeLists.txt would you accept that?

tsaubergine commented 4 years ago

If I added an install statement in each app's CMakeLists.txt would you accept that?

Yes, that's fine with me, probably the better solution anyway. I guess the debian packing tools strip the RPATH as I don't see it on an .deb installed binary, but I do see if I do "make install" locallay.

russkel commented 4 years ago

That seems to have done the trick.

tsaubergine commented 4 years ago

Thanks!

tsaubergine commented 4 years ago

Could you please also sign (add your name, date, email) to the CLA agreement in https://github.com/GobySoft/dccl/blob/3.0/AUTHORS and push to this (or another) branch? I missed asking you to do this on your first PR. Thanks!

russkel commented 4 years ago

Sure. #65