search

GobySoft / dccl

Dynamic Compact Control Language
Other
17 stars 13 forks source link

Force python setup.py to use the "-std=c++11" flag for install #71

Closed edsanville closed 2 years ago

tsaubergine commented 2 years ago

@chrismurf, @kguilbert - have you been using the Python package for DCCL? If so have you run into this?

@edsanville I assume you're using Ubuntu 20.04?

chrismurf commented 2 years ago

I haven't used it in a while, I'm (unfortunately) living more on the C++ these days... Except when I'm messing about in Rust :-)

At any rate, no objections at all to requiring C++11 or greater at this point.

tsaubergine commented 2 years ago

Thanks @chrismurf. I'm just going to merge this as I doubt it'll break anyone who is using anything modern, and obviously fixes a problem for @edsanville.

edsanville commented 2 years ago

Thanks @chrismurf. I'm just going to merge this as I doubt it'll break anyone who is using anything modern, and obviously fixes a problem for @edsanville.

Thanks for this. I'm actually running on macOS, and the clang compiler defaults to C++98 apparently. The python module gave me an error and explicitly told me it requires >= C++11, so adding that argument fixed the issue.