search

GobySoft / dccl

Dynamic Compact Control Language
Other
17 stars 13 forks source link

Feature: Report FindInitializationErrors() on IsInitialized() failure. #93

Closed psmskelton closed 1 year ago

psmskelton commented 1 year ago

Currently, debugging missing required fields is a blind and labourious process, especially on complex and/or nested messages.

While still using required fields (noting they have been removed in Protobuf 3), the call to IsInitialized() (e.g., https://github.com/GobySoft/dccl/blob/4.0/src/codec.cpp#L206) should call FindInitializationErrors() upon failure.

Patch to be submitted soon.

tsaubergine commented 1 year ago

Please put a PR for this suggested fix and I'll be happy to review it.

psmskelton commented 1 year ago

Apologies, completely forgot with holidays. Will find what I implemented and submit a PR this week.