search

GobySoft / goby3

The Goby Underwater Autonomy Project Version 3
Other
24 stars 11 forks source link

goby_logger does not always embed required extension messages #247

Closed tsaubergine closed 2 years ago

tsaubergine commented 2 years ago

If a message has an extension, the extension message isn't always embedded in the .goby file.

Also, extensions don't seem to be written by the --format=JSON at all.

tsaubergine commented 2 years ago

.protos are now embedded (as of #253). Need to update DCCL to allow an option for it to search the user pool first for calls to DynamicProtobufManager::find_descriptor so that goby_log_tool can find messages with extensions in the user pool but exist in the generated pool (e.g. FrontseatData).

tsaubergine commented 2 years ago

Fixed in DCCL4 / Goby 3.0.10