Gocnak / Botnak

A Java-based IRC chat client with focus on Twitch.tv streams.
https://gocnak.github.io/Botnak
MIT License
67 stars 28 forks source link

!volume, logging and small bug fixes #110

Closed ChristopherWirtOfficial closed 9 years ago

ChristopherWirtOfficial commented 9 years ago

I implemented the !volume command in the form !volume float where float is a float between 0.0 and 100.0 (with error checking of course) If you just type !volume then you get the current volume.

I implemented a check for the logging that checks if the object passed to it is a Throwable (i.e. an Exception) and if it is, will log the stack trace instead. I then implemented this in the FFZ loading to find a bug

When trying to load the API, if you don't have the FFZ SSL certificate in your truststore (which is really really finicky, even if you've been to that site and accepted risks) then you get an exception and fail to load them. Now we ... sorta .. ignore it. It was self-signed, so we can't trust it no matter what, so we just ignore the SSL check all together.

Fixed a "bug" where if you typed the name of a sound command like !sound and hit save, the command created was !!sound. So now it won't do that.

I replaced all of the places that used e.getMessage() for logging by keeping any existing text like "Blah failed because of exception: " and doing an additional log of just the exception on the next line.

I'll probably go through and clean up some of the try-catch blocks to be more explicit on what they're catching and also make sure there aren't other exceptions that aren't being logged, but I'll save that fun for after the new GUI gets pushed.

Gocnak commented 9 years ago

For FFZ, they're self signed, but http works instead? Should we continue to use https with your fix or just swap over to http?

Gocnak commented 9 years ago

Re-open this with the request on the new-guis branch, please.