search

Gocnak / Botnak

A Java-based IRC chat client with focus on Twitch.tv streams.
https://gocnak.github.io/Botnak
MIT License
67 stars 28 forks source link

Username completion #117

Closed Palehors68 closed 9 years ago

Palehors68 commented 9 years ago

I updated the username completion functionality to mimic twitch chat.

  1. Reduce characters necessary to search for users from 3 to 2
  2. Remove @ sign requirement to search for users
  3. User can force a search using the tab key
Gocnak commented 9 years ago

I see an issue with no longer requiring the '@' to mention people.

Would name suggestions be popping up when people are just typing normal words? For example, typing "the" would most likely pop up some suggestions in a big chat.

Palehors68 commented 9 years ago

To use username completion without the @ sign, the user is forced to press the Tab key. Also, to cancel the username popup, the user should press Esc. Without pressing Esc, shouldShow doesn’t get set to false and the suggestion box keeps appearing. I think that wasn’t clear in my notes.