search

GodKratos / bittorrent-webui

Automatically exported from code.google.com/p/bittorrent-webui
18 stars 8 forks source link

Does no longer work with qBittorrent 3.2 #25

Open Froghut opened 9 years ago

Froghut commented 9 years ago

There were changes to the webUI api on how to authenticate in qBittorrent 3.2 so the old method no longer works.

dcrystalj commented 8 years ago

very frustrating

aybabtu123 commented 8 years ago

I am having this issue also.

phebal commented 8 years ago

Made a pull request with a dirty fix for the issue. Hopefully it'll get merged. If not, here as link to an installable addon that includes the fix: https://github.com/phebal/bittorrent-webui/blob/qbittorrent-auth-fix-release/releases/bittorrent_webui-0.2.3.1-fx-qb_fix.xpi

bobthebigbat commented 8 years ago

Can you please fix this.

reb00tz commented 7 years ago

@phebal: Are you able to submit this to AMO for signing? I am unable to install it without ESR/dev/nightly builds instead of stable FF as there is no way to turn off addon signing otherwise.

phebal commented 7 years ago

@reb00tz I can still install this on FF 49.0. Setting xpinstall.signatures.required to false doesn't work for you?

reb00tz commented 7 years ago

@phebal Hi, thanks for the prompt response and follow-up. No, it does not work on stable FF 49.0.1/49.0.2 even with the xpinstall.signatures.required = false.

phebal commented 7 years ago

@reb00tz That sucks, I'm not sure what gives. I'm on Fedora, so maybe that has something to do with signing being configurable. Anyway, this addon uses an outdated API (not that I'm an expert on FF API but I was getting deprecation warnings in the debugger) and would probably never get accepted. It looks abandoned too sadly. I wish I had time to develop something.

reb00tz commented 7 years ago

@phebal I updated the install.rdf file, providing updates, giving you credit and pointing back to this thread as source, then managed to get it signed by Mozilla (which I have attached here) - this required fudging the addon ID to make sure it did not clash with the existing HEAD. Apologies to the world at large if this is not considered "good manners", but I do not know any easier way.

Unfortunately, testing it with magnet links results in HTTP 403... (AUTH errors). Looking at the qBittorrentDispatcher.js, it appears that the Authorisation header value is missing. From the API, it is supposed to be a HTTPDigestAuth of the stored username and password.

I suppose the code to generate and inject this into the header should be in place of line 95 in, as well as replacing code in lines 102-104?

Any ideas? bittorrent_webui-0.2.3.2-fx_qbt_fix_signed.zip 2016-11-27_01-27-23 2016-11-27_01-29-43 2016-11-27_01-33-32

GodKratos commented 7 years ago

I've committed a fix for this however Mozilla are refusing to approve latest version of the addon since it uses asynchronous HTTP requests (which it always did). I'll need to rewrite the entire addon in a different way to get it properly approved now.

There is a workaround to disable authentication in qBittorrent that should make it continue to work without changing the addon. https://github.com/qbittorrent/qBittorrent/wiki/Disable-authentification-of-webGUI

mozreactor commented 7 years ago

Cool to see you updating for qBittorrent! I've been sorely missing the extension. Did you notice, though, that it's not working under e10s? https://github.com/GodKratos/bittorrent-webui/issues/22

stormwatch commented 6 years ago

I installed the plugin from the master branch in order to try the fix but now I get "The address wasn't understood" when clicking on a magnet link and clicking on the add-on preferences yelds no dialog window.