search

Goddard-Fortran-Ecosystem / gFTL

Software containers for Fortran
Apache License 2.0
41 stars 10 forks source link

gFTL installs spurious "Foo" includes #96

Closed olebole closed 4 years ago

olebole commented 4 years ago

In include/types, gFTL installs the files Foo.inc, FooPoly.inc, FooPolyPtr.inc, and FooPtr.inc. These require modules which are not available: 

use Foo_mod, only: Foo

This looks like example files; shouldn't they be installed as examples?

tclune commented 4 years ago

Not examples, per se, though that might be a good idea. They were introduced in the early days for testing the functionality with derived types. Testing became more sophisticated later on and these are duplicated in the tests/include/types where there is a Foo module.

I've just pushed a fix that eliminates these, but have only done a very quick test. I will now merge with develop. Let me know if you need a formal release.

olebole commented 4 years ago

I can also remove them manually in the Debian package, no problem. BTW, I am not sure whether I already said that I am going to create official Debian packages for it. Announcement here. Similarly for gftl-shared, fargparse and pfunit.

tclune commented 4 years ago

Cool! If you did mention it before, I missed it.

Thanks!