Protect REAL128 in Assert_Complex

Goddard-Fortran-Ecosystem / pFUnit

Parallel Fortran Unit Testing Framework

Other

174 stars 45 forks source link

Protect REAL128 in Assert_Complex #362

Closed havogt closed 2 years ago

havogt commented 2 years ago

Enables compilation with nvhpc (tested with 22.3).

Maybe related to discussion in #337.

havogt commented 2 years ago

After debugging the segfault described in #363, I noticed that this fix seems to be needed in some environments (e.g. my laptop with openSUSE tumbleweed), but not in all environments (e.g. not in the ubuntu based docker container that is mentioned in #363).

havogt commented 2 years ago

Note that Assert_Real has these #ifdefs https://github.com/Goddard-Fortran-Ecosystem/pFUnit/blob/26ac761630dd3012081d67ce03ee99bff2dbe8d9/src/funit/asserts/Assert_Real.tmpl#L129. I just copied from there and it fixed my problem. (In the meantime I upgraded my system and cannot reproduce the failure anymore.)

tclune commented 2 years ago

Yes - the #ifdefs there are also unnecessary. Probably not worth fixing, but I'll try to remember the next time I make a change.