Goddard-Fortran-Ecosystem / pFUnit

Parallel Fortran Unit Testing Framework
Other
172 stars 45 forks source link

Add pfunit-mpi-defines ALIAS #365

Closed mathomp4 closed 2 years ago

mathomp4 commented 2 years ago

Recent testing with the GFE repo showed that make tests seems to have a currently unexplained issue with the pfunit-mpi-defines target:

CMake Error at /Users/mathomp4/installed/MPI/gcc-gfortran-11.3.0/openmpi-4.1.3/Baselibs/7.4.0-TEST/Darwin/PFUNIT-4.4/cmake/PFUNITTargets.cmake:37 (message):
  Some (but not all) targets in this export set were already defined.

  Targets Defined: PFUNIT::funit;PFUNIT::pfunit

  Targets not yet defined: PFUNIT::pfunit-mpi-defines

Call Stack (most recent call first):
  /Users/mathomp4/installed/MPI/gcc-gfortran-11.3.0/openmpi-4.1.3/Baselibs/7.4.0-TEST/Darwin/PFUNIT-4.4/cmake/PFUNITConfig.cmake:113 (include)
  yaFyaml/CMakeLists.txt:30 (find_package)

-- Configuring incomplete, errors occurred!
See also "/Users/mathomp4/Baselibs/ESMA-Baselibs-7.4.0-TEST/src/GFE/build/CMakeFiles/CMakeOutput.log".

This seems to have happened to any add_subdirectories of GFE that are after the pFUnit add. So gFTL and fArgParse worked, but yaFyaml failed.

I'm not exactly sure what the bits added by @ZedThree for pfunit-mpi-defines do, but if we add an ALIAS library for that, the make tests on GFE seem happy.