search

Goddard-Fortran-Ecosystem / pFUnit

Parallel Fortran Unit Testing Framework
Other
173 stars 45 forks source link

Draft: Update pFUnit to use v2 template interfaces #464

Closed cferenba closed 2 months ago

cferenba commented 4 months ago

This adds the changes needed for pFUnit to build using the v2 versions of the template interfaces.

Note that this PR depends on Goddard-Fortran-Ecosystem/fArgParse#142 and will not build without it.

Resolves #463.

cferenba commented 4 months ago

Sorry, I got pulled aside to other things and haven't gotten back to this. @tclune please review...

tclune commented 4 months ago

Same here. Vacation combined with official travel. I have the ticket pegged in my inbox. Hopefully can review sometime this week. Quite jet-lagged at the moment though.

cferenba commented 4 months ago

Quite jet-lagged at the moment though.

Understood. Whenever you are able to get to it is fine.

tclune commented 3 months ago

@cferenba Sorry for the delay. Finally got around to reviewing. Looks fine but CI looks to have had a weird issue. I'll discuss with my software stack person (@mathomp4) tomorrow.

cferenba commented 3 months ago

Looks like the CI is looking for an fArgParse hash that is in Goddard-Fortran-Ecosystem/fArgParse#142 but isn't in develop yet.

tclune commented 3 months ago

Looks like the CI is looking for an fArgParse hash that is in Goddard-Fortran-Ecosystem/fArgParse#142 but isn't in develop yet.

Yeah - should have read the "conversation" rather than just staring at the changes. I've approved the fArgParse PR, but you'll need to at least touch the ChangeLog for CI to be happy there. If the branch were local I would have done that for you.

tclune commented 2 months ago

I've created a new PR that brings in your changes to fArgParse. Closing this one.