search

Goddard-Fortran-Ecosystem / pFlogger

A parallel Fortran logger (based on the design of the Python logger)
Other
18 stars 8 forks source link

Stray prints in pFlogger #74

Closed mathomp4 closed 2 years ago

mathomp4 commented 2 years ago

In running GEOS with MAPL3 I noticed some stray prints:

 Config.F90          87 F T           4
 Config.F90          89 T
 Config.F90          90 plain
 Config.F90          87 F T           4
 Config.F90          87 F T           4
...

After searching through MAPL and realizing they weren't in there, I figured it was a GFE library. And I think it's from this:

https://github.com/Goddard-Fortran-Ecosystem/pFlogger/blob/767421fc682d88c26828091ee4e861c2fa9834b5/src/Config.F90#L85-L92

I can make a PR (assuming these aren't needed), and I just need to know if I should hotfix or just put onto develop where there already is a bit of a "cleanup" change:

https://github.com/Goddard-Fortran-Ecosystem/pFlogger/compare/develop

tclune commented 2 years ago

Oops. I guess technically it is a bug in that pFlogger is all about I/O and should not produce "extra". So do a hot fix.