search

Goddard-Fortran-Ecosystem / yaFyaml

Yet Another Fortran YAML
Apache License 2.0
13 stars 8 forks source link

Remove stops, another step to more robust error handling #58

Closed bena-nasa closed 2 years ago

bena-nasa commented 2 years ago

I removed all the "stops" in routines and replaced with proper error returns. At the very least I can now check when parsing files in a layer using this if the parsing failed and report. As @tclune said, probably places we are missing rc calls up the calling tree, but this is at least a first step.

I also had to change the name of the "verify" subroutine in the errorhandling module. Turns out Fortran has an intrinsic verify that was being used in a few routines and well, you can imagine, the compiler got confused...

mathomp4 commented 2 years ago

Weird. Why would gcc 9 work on Ubuntu 20 but fail on macOS 11 and gcc 11 work on macOS 11 but not on macOS 12?

bena-nasa commented 2 years ago

@tclune made the requested changes and pushed

mathomp4 commented 2 years ago

Okay. I've pulled in my test changes into here too.

@tclune should I just turn off the macOS-gfortran9 test?