Godiesc / firefox-gx

Opera GX Skin for Firefox
Mozilla Public License 2.0
798 stars 41 forks source link

Tabs Glitch When Certain Themes Are Applied #113

Open OleExploder opened 8 months ago

OleExploder commented 8 months ago

Whenever I apply certain themes, the color in the active tab glitches out and does not match with the rest of the theme's color. Screenshot 2023-12-22 010146

Godiesc commented 8 months ago

hi, you should read the patch notes of this new version of the theme, I said that "tab-shapes" config can't align the selected-tab background with the background behind; sadly this seems to be unsolvable.

OleExploder commented 8 months ago

Ok, thank you.

Godiesc commented 8 months ago

This bug will solve in the next release of the theme, I was able to solve it.

OleExploder commented 8 months ago

That's cool, thank you!

Godiesc commented 8 months ago

@OleExploder A new release of the theme was made, can you test it to see if all works fine?

OleExploder commented 8 months ago

I am sorry for the late reply but I tested it and everything looks better from what I have seen. Btw, are the tabs supposed to be opaque unlike the address bar? Screenshot 2024-01-10 184629

I also want to note that a similar issue still happens when dragging a tab as well.

Godiesc commented 8 months ago

when "dragging a tab" is a unsolvable bug, but the theme should looks well in the selected tab, I notice some themes with images can't align the image, I don't know why. other themes looks right like this: https://addons.mozilla.org/es/firefox/addon/geometric-fury/

OleExploder commented 8 months ago

I see, thanks.

Godiesc commented 8 months ago

I was working on solution and seems I find out, I added this code, you can added for now in ogx_tricks.css:

  :root:is([lwtheme-image]){
  --lwt-background-alignment: right top !important;
  }

This solution will be include in the next release of the theme.

OleExploder commented 8 months ago

I tried adding that but nothing seemed to change and I could've done that wrong by using Notepad but I am not sure.

Godiesc commented 8 months ago

All themes seems fine for me with that fix:

imagen

imagen

imagen

OleExploder commented 8 months ago

Looking at it again, same thing actually using one of the themes you listed in your comment so I think it might've worked but some themes still actually have the tab itself in a different color compared to the address bar such as this theme and dragging the tab looks the same even with that fix but I think it would be hard to fix like you said.

Godiesc commented 8 months ago

It seems that themes that use transparencies in its images will have that problem, that theme you share use a svg image that just put the lines on repeat but the blue color is not part of the image, is part of the --frame color, that is why the problem appear. That That will become a permanent issue, I will add that info to the page. Thanks for your report.

OleExploder commented 8 months ago

You're welcome and thanks.