Tab line issue on macOS

[Tintouin]

As you can see there

The line is not properly finished. It was on installation and the first time I set up the left bar, but upon relaunching it stopped working.

How can I fix his issue ?

[Godiesc]

hi, sorry for that bug, I'm currently updating the theme to solve various issues, with the actual version of firefox I changed the way that line display but is so inefficient. for now you can add this code into components/ogx_tricks.css file:

#TabsToolbar::before{
        content: "" !important; position: absolute !important; align-self: end !important;
        width: 40px !important;
        height: 1px !important;
        min-height: 1px !important;
        max-height: 1px !important;
        left: 0 !important;
        width: 40px !important;
        border-bottom: 1px solid var(--general-color) !important;
    }

pd: let me know if work. ❤️‍🔥

[Tintouin]

hi, sorry for that bug, I'm currently updating the theme to solve various issues, with the actual version of firefox I changed the way that line display but is so inefficient. for now you can add this code into components/ogx_tricks.css file:

#TabsToolbar::before{
        content: "" !important; position: absolute !important; align-self: end !important;
        width: 40px !important;
        height: 1px !important;
        min-height: 1px !important;
        max-height: 1px !important;
        left: 0 !important;
        width: 40px !important;
        border-bottom: 1px solid var(--general-color) !important;
    }

I did exactly this nothing has changes even after releaunch. I believe its due to some change I did since it wasn't always there...

[Godiesc]

sorry, I don't have mac and cant tested before give you the code, but I think it works but with a higher number of the width number, try something like this:

#TabsToolbar::before{
        content: "" !important; position: absolute !important; align-self: end !important;
        height: 1px !important;
        min-height: 1px !important;
        max-height: 1px !important;
        left: 0 !important;
        width: 140px !important;
        border-bottom: 1px solid var(--general-color) !important;
    }

[Tintouin]

sorry, I don't have mac and cant tested before give you the code, but I think it works but with a higher number of the width number, try something like this:

#TabsToolbar::before{
        content: "" !important; position: absolute !important; align-self: end !important;
        height: 1px !important;
        min-height: 1px !important;
        max-height: 1px !important;
        left: 0 !important;
        width: 140px !important;
        border-bottom: 1px solid var(--general-color) !important;
    }

Okay I didn't noticed that the width parameter could have an effect.

So 140px were a bit too much:

I've set it to 100px but it still wasn't perfect:

As you can see there is one pixel that breaks the outline here it is zoomed out:

So I've set it at 99px which was perfect:

I think that you can commit this modification for mac since it not only fixed the left-sidebar version but it also fixed the default settings:

to

My code is:

#TabsToolbar::before{
      content: "" !important; position: absolute !important; align-self: end !important;
      height: 1px !important;
      min-height: 1px !important;
      max-height: 1px !important;
      left: 0 !important;
      width: 99px !important;
      border-bottom: 1px solid var(--general-color) !important;
  }

I only changed the width

[Tintouin]

Also if you're looking for a macOS tester I can provide useful infos on beta and settings, I plan to port my TF2 GX mod (https://store.gx.me/mods/qujam3/tf2-natural-gx-mod/) to firefox through your addon and a few other extensions so I'll be messing around with it quite a bit and I was following your project for quite a long time now. You can email me anytime I guess.

I can on a much less frequent extent provide test for linux distros, just ask me.

[Godiesc]

thanks for testing the code, I will update the code in a few minutes so I would like you to test it from code -> download zip

[Tintouin]

Thank you, I'll certainly give more feedback since im now using firefox GX as my daily browser.

[Godiesc]

I updated the theme, and I would like to know too how looks the contextual menu with the icons added in this new update, you can disable the icons with this in about:config if the contextual menu becomes weird:

firefoxgx.icon.disabled

[Tintouin]

Nothing seems to have changed, even with the config, what is the expected behavior ?

Also, we should open a discussion about macOS compatibility to exchange about tests and everything rather than in this issue.

[Godiesc]

for example the menu in windows and linux looks like this:

and I will create the discussion jut now.