Godiesc / firefox-gx

Opera GX Skin for Firefox
Mozilla Public License 2.0
794 stars 40 forks source link

popups border has shown up in the new nightly versions #149

Closed Fyrnx closed 5 months ago

Fyrnx commented 5 months ago

i updated nightly about 2 day ago and some codes stop working i found that

lift-sidebar: now has a transparent background the

one-line: still not working properly ( i fixed some bugs in it manually before but it showed more bugs after the update )

and the more important thing is that now there is a huge white border in every popup i tried to remove it by this code

panel.panel-no-padding::part(content) {
  border: none !important;
}

the strange thing is this code works when trying it in the developer tools in a inline-style but when i added it to the custom codes in the addon it didn't work

the new version of nightly is Nightly 126.0a1 (20240319215652)

Godiesc commented 5 months ago

Thanks for the report, I checked and a lot of bugs appeared in Nightly, hope all have solutions.

Godiesc commented 5 months ago

@Fyrnx I updated the theme, you can tested from code->download zip to see if all the problems are solved.

Fyrnx commented 5 months ago

it didn't fix the main problem for me the white border around the popups but i think its a problem in my side or one of the addons i have

can you give me the code for the tabs style only

can you provide the documentation for how to make custom style like this because i don't know how to use @media (-moz-bool-pref) probable and is there something like for string and numbers

Godiesc commented 5 months ago

mm, I tested and seems right, I don't know if an extension can make that issues, but I don't know.

imagen

can you give me the code for the tabs style only

the problem with Nightly version was some global selector so I don't make big changes into specific styles to solve those problems, I don't know what tab style you ask.

can you provide the documentation for how to make custom style like this

I don't know what you mean with this.

Fyrnx commented 5 months ago

are there any documentation for how to make custom userChrome because there is some features not in normal css

Godiesc commented 5 months ago

I don't get it, for your custom css you can add it into chrome/components/ogx_tricks.css file, for activate "Extra" features you have links with the steps to do.

Fyrnx commented 5 months ago

can you just explain this code

@media (-moz-bool-pref:"firefoxgx.left-sidebar") {}

i know it checks if the value of firefoxgx.left-sidebar in the about:config is true if it's true it runs the codes

so if the firefoxgx.left-sidebar was a string how can i use @media to check it's value

if your are not sure what this code does or what i mean no problem you solved the main issue so i will just close this issue

Godiesc commented 5 months ago

mm, that check is made for the browser, for example in this new example the code is run when the first is true and the second is false, you have extended info in internet for example here: @media queries or @media w3school

@media (-moz-bool-pref:"firefoxgx.tree-tabs") and (not ( -moz-bool-pref:"firefoxgx.oneline")){..}