Godiesc / firefox-gx

Opera GX Skin for Firefox
Mozilla Public License 2.0
798 stars 41 forks source link

Context menu and other 'menu' content on windows is too large, theme overrides website styling #68

Closed arijitroy454 closed 1 year ago

arijitroy454 commented 1 year ago

The context menu options are too large in windows image image

This also happens with other menus in certain websites, where this theme overrides the default menu with a very large and fat menu.

This is the default menu on myanimelist image

And this is what this theme replaces it to be like. This is too large, too wide and fat, and I feel there is no need to replace. image

I also feel that replacing the default placeholder text for 'My Account' written in a weird font with this looks much better. Imo the font looks very out of place. image

image Either this or just "Firefox Account" in normal font

Godiesc commented 1 year ago

hi, 1.- the contextual menus are edited in ogx_contextual-menu.css and if you don't like them at all you can delete the file from chrome/components folder.

2.- for "The context menu options are too large in windows" you mean the height of each row is to much? you can try editing the file ogx_contextual-menu.css, the lines 7 and 149 to a smaller number and see if that works. I intentionally did the contextual menu to show "back, forward, reload, bookmark" like rows, that could give that menu a higher space.

3.- The css apply to all contextual menus, so I can´t control the aspect of different menus on Firefox or in certain websites. For example, in menus like the image below for some reason Firefox affect that menus with the same css, I don't know if exist a way to don't affect that menus in websites, I didn't edit that menus intentionally. imagen

4.- The "Firefox Account" label was made for manually edit for the user with his Name or nickname, maybe in the next release of the theme I replace that wit something like this "My Firefox Account" with the default font, Thanks for the suggestion.

arijitroy454 commented 1 year ago

Got it, and yes the css change fixed the issues for me.

Question, is there a way to decrease the size of the size of this menu aswell? like with the context menu, where you suggested a css edit. image

Godiesc commented 1 year ago

this is a code I will add in the next release version of the theme, you can add in theogx_contextual-menu.css

#ContentSelectDropdown > menupopup > menuitem {
  padding: 0 6px !important;
}