Godiesc / firefox-gx

Opera GX Skin for Firefox
Mozilla Public License 2.0
798 stars 41 forks source link

Tricks and settings questions #74

Closed soilentgreen closed 1 year ago

soilentgreen commented 1 year ago

Hello again Godiesc,

Have some questions hope you can help me with:

1) I try to do the "Image in menus (contextual menu and arrowpanel menus)" trick but it won't work. I copy past the code to ogx_tricks.css and put it in components. Do I need to add image to anywhere for it to work?

2) Can we change the background of "settings" to black from dark? and change the fonts to another color?

3) Something you might wanted to know. When I did the "Extensions button into the "left-sidebar" ", it worked the button moved left but on the first icon I have on the sidebar. The only fix for me was to change the code from "top: 76px !important;" to "top: 395px !important;" and it moved it below my all icons. When I tried to move it above my first Icon it look bed because it was too close to the "menu" icon.

Thank again

Godiesc commented 1 year ago

hi, 1.- "Image in menus (contextual menu and arrowpanel menus)" trick works in themes that have images, try one and let me know if works, for example this: https://addons.mozilla.org/es/firefox/addon/beautiful-red-blur/

2.- I don't understand the second question, try to show a screenshot and some annotation to see what you want, what font color(all the font color or of some section or...), aand change black to dark is the same meaning for me, maybe you wrote wrong.

3.- The extensions button should be position in the top of the sidebar below the menu button (as it shows in the preview image), I will test soon.

soilentgreen commented 1 year ago

hi 1) didn't work with Beautiful Red Blur theme. attached the ogx_tricks.css maybe the code not right?
ogx_tricks.zip

2) attached image of the settings. can we BG it in pure black? and can we color the font in red? 1

3) attached image of the Extensions when it on 76px. as you see the Extensions is on the setting button. 2

Godiesc commented 1 year ago

1.- the first line of your file isn't right, you need to add symbols like this: / / in the beginning and end of informative text, for example:

imagen

when "Main-image" config is on, the background that the theme manage are two, the one of the theme and the one we set manually, the image in the contextual menu will be taken of the theme, is a little fade, maybe you don't see clearly. that config just works when you have active a base theme that use images in about:addons.

2.- to change all the background to totally black and fonts on red something like this? the file that give it the colors is: ogx_UC-settings-addons-pages.css

imagen

3.- For fix the wrong position of the extension button you should try change the next line to 182 maybe, you should test with a bigger number, is the easy way to move all the icons down.

imagen

soilentgreen commented 1 year ago

hi and many thanks :-) I started with 2. can you tell me the lines you changed? I changed to black lines 71 and 72 and for the red font 56, 57 and 92 there is one line of black BG I cant find. 1

Godiesc commented 1 year ago

I added this code block after line 176 :

/* color fondo grande */
    .main-content{
    background: black !important;
    color: red !important;
}

imagen

soilentgreen commented 1 year ago

about the bg settings it worked thanks to you 1

about the extensions, 182 and bigger numbers didn't work. the icon didn't moved. but its fine I like how it look with "top: 395px !important;"

About the "Image in menus" it didn't work. you told me that the first line of the code is wrong. but i copy past the code as it is, and it look as the pic you upload. and so is mine:
11

Godiesc commented 1 year ago

you told me that the first line of the code is wrong. but i copy past the code as it is I said you the first line of your file, and I don't know if having that affects the fist code block and for that the change to 182 didn't work for you.

imagen

soilentgreen commented 1 year ago

Godiesc about the icon its no big deal. it is possible the "Image in menus" don't work because of firefox color? I tried with this theme too. https://addons.mozilla.org/en-US/firefox/addon/beautiful-gx-fantasy/ and thank you very much for help me :-)

Godiesc commented 1 year ago

try to keep a good format of the css or the code will fail in ways you can't image jeje

The code for move the extension button works fine, the button is moved to the top icons in the left-sidebar.

imagen

for the contextual menu the code works fine, but is a little opaque, so maybe you should try the new number (the 2 latest numbers write 90 or less) in the lines that a mark in the next picture, to make the image more visible.

imagen

soilentgreen commented 1 year ago

hi so now the Extensions button move as it should :-)

but the contextual menu the code wont work. I notice that my themes look different than yours. I do not have the red blur as yours. maybe it block some how? look at the pic only black: Untitled

soilentgreen commented 1 year ago

yes when I turn off firefox color Image in menus works. that was the problem. thank you for your help. again :-)

Godiesc commented 1 year ago

for the background you should add the next code in ogx_UC-settings-addons-pages.css:

#content{
            background: black !important;
        }

imagen

soilentgreen commented 1 year ago

thank you for that!!! :-) Godiesc, I must tell you, you are one of the most helpful and tolerant devs I ever see. there is few, but not a lot.

thanks for your help and for help me create so beautiful theme :-)

I wish I could use firefox color with "Image in menus" trick but If I should choose, firefox color gives a lot more customization from that trick.

Godiesc commented 1 year ago

Anytime. If you know basic css and use the console of the browser you can change everything in the browser. :)

soilentgreen commented 1 year ago

No I do not know...

By the way maybe you want add to the "Image in menus" trick page, that it wont work with firefox color, because on the main page of the theme you recommend to use firefox color. Just a thought.

Godiesc commented 1 year ago

I will put a warning in that style, thanks for the advise.

soilentgreen commented 1 year ago

Hi Godiesc,

There's few places I want to changed the font color to red. (Just so you know if you don’t have time its fine, you helped me so much already so I’ll understand :-) ) This is the places: 1) New tab 2) Search bar 3) Close confirmation Thanks again. 1 2 3

Godiesc commented 1 year ago

hi, in ogx_root.css you will find a lot of variables that change the colors in general for dark and light mode.

the line 18 will solve 1-2-4 of your question.

--lwt-tab-text: #ff0000 !important;

imagen

for "3" the easy way is to change the line 36 but will affect other text and change to red too. Tested and see if all seems fine.

--newtab-text-primary-color: #ff0000 !important;

imagen

for "5" you need to use the ogx_notifications.css and add a line after line 17:

--in-content-page-color: red !important;

imagen

soilentgreen commented 1 year ago

Worked like a charm :-) Thank you !!! 1 There is a way to color the "Close tabs" to black and the "Cancel" to red? 2

Godiesc commented 1 year ago

in ogx_notifications.css From the line 74 replace that code block with this:

    --in-content-primary-button-background: black !important;
    --in-content-primary-button-background-hover: var(--general-color) !important;
    --in-content-primary-button-background-active: var(--button-active-bgcolor) !important;
    --in-content-primary-button-text-color: white !important;
    --in-content-button-background: #ff0000 !important;
    --in-content-button-background-hover: #ff3030 !important;

imagen

soilentgreen commented 1 year ago

Didn't work I don't know if I was clear but I want to change the font color not the BG 1

soilentgreen commented 1 year ago

So I changed the close tab font. can I change the cancel font to red? 1 Untitled

Godiesc commented 1 year ago

This could work. --in-content-button-text-color: red !important;

soilentgreen commented 1 year ago

hi Godiec, so with your help I somehow succeeded to make it as I wanted :-) thanks again (and again) for your help.

https://github.com/Godiesc/firefox-gx/assets/7990597/62801eaf-c0e7-43bb-af76-8f3bf886b42d

--in-content-primary-button-background: var(--button-active-bgcolor) !important;

--in-content-primary-button-background-hover: var(--general-color) !important;

--in-content-primary-button-background-active: var(--button-active-bgcolor) !important;

--in-content-primary-button-text-color: black !important;

--in-content-button-background: #343d46 !important;

--in-content-button-background-hover: #BF0609 !important;

--in-content-button-text-color: red !important;

--in-content-button-text-color-hover: black !important;

Godiesc commented 1 year ago

You're welcome.