Godiesc / firefox-gx

Opera GX Skin for Firefox
Mozilla Public License 2.0
798 stars 41 forks source link

This theme conflicts with "clipboard2file" extension #81

Closed zWolfrost closed 1 year ago

zWolfrost commented 1 year ago

I had just installed "clipboard2file" extension (to emulate the behavior of opera gx "select clipboard image" feature) when I found out that this theme would conflict with it (see image below)

Specifically, the culprit lines are "6" and "30" from "ogx_UC-settings-addons-pages.css" and lines "561" and "568" from "ogx_UC-newtabpage.css".

If these lines can be removed or replaced in a way that doesn't conflict with this extension i would really be happy (even though i don't know what they are for). But even if they are important in some way, i felt like noting that out for people who have the same problem.

Please close this issue if nothing can be done about it.

zWolfrost commented 1 year ago

Also note that to use the extension (if someone wants to test it) you have to set "dom.events.asyncClipboard.clipboardItem" to true in "about:config" (as written in its description)

Godiesc commented 1 year ago

hi, thanks for the report, is an interesting add-on, the lines you mentioned are for the background-color of the about: pages, it seems like that extension in some way use that url or something like that, rare. I will tested and see if a solution is possible. @zWolfrost I hope you can list some "steps to do" to test, I don't know how that extension works.

zWolfrost commented 1 year ago

Hi, thank you for your time. As i said above, you don't need to do a lot to replicate this behavior. You just need to install the add-on and set "dom.events.asyncClipboard.clipboardItem" to true in "about:config" (to make it work at all, as the add-on specifies in its description). Then, just copy an image and try to upload it by pressing whatever image upload button, like google reverse image search or imgur. I will add a screenshot of how it's supposed to be instead (i removed the previously stated lines).

image

Godiesc commented 1 year ago

the extension is rare, we can upload the image with Ctrl + v, or maybe is for sites that can't do that. lucky that the function of the extension isn't affected.

Godiesc commented 1 year ago

@zWolfrost I updated the file ogx_UC-settings-addons-pages.css to solve the problem, thanks for your report.

zWolfrost commented 1 year ago

Thank you very much for fixing the background, however i also asked to replace in some way lines "561" and "568" from "ogx_UC-newtabpage.css" because they make the extension background white for some reason. Is what i've described normal?

image

Godiesc commented 1 year ago

it happens in dark mode for content? imagen

zWolfrost commented 1 year ago

Yes, i have already set the appearance to Dark, and that still happens.

Godiesc commented 1 year ago

hi again, I made a little change to the ogx_UC-newtabpage.css file to solve that, thanks for the report. 💙