Godiesc / firefox-gx

Opera GX Skin for Firefox
Mozilla Public License 2.0
798 stars 41 forks source link

Some menus will open outside the window to the left sometimes. #94

Closed matt1432 closed 10 months ago

matt1432 commented 10 months ago

Thank you for the beautiful theme! I've always loved Opera GX's UI but the chinese spyware is a bit of a deal-breaker for me, so thank you for bringing this to Firefox.

However, when the firefox window isn't taking up the entire monitor, the main menu opens to the left (see picture).

This also happens when installing an addon, where it always shows up to the left and doesn't allow me to enable the addon in private tabs.

image

Godiesc commented 10 months ago

hi, for default the redesigned menu will appear only with maximized window, in normal window will appear the default form, like this:

imagen

you can add extra info like your OS, version of Firefox, version of the theme, extra features activated, or maybe your OS simulate maximized windows when it doesn't? who knows.

matt1432 commented 10 months ago

I have had this issue on 2 machines

Additional info: OS : Linux NixOS and Archlinux WM/DE: Hyprland or KDE Firefox 119 with version 8.5 of this theme Firefox 118 with version 8.4 of this theme

I have tab shapes and left sidebar on

matt1432 commented 10 months ago

Is there a way to always force the default form? That could help with my issue

Godiesc commented 10 months ago

in your screenshot I see you have other window in the left side, so its the feature of the OS for put different windows on the sides, linux allows you to have up to 4 windows in the corners of the screen, are you using that, I guess, maybe that the browser interprets like maximized, don't happens in windows-10. I will test in manjaro-kde if the problem is that, maybe could search for a solution.

Is there a way to always force the default form? That could help with my issue

maybe deleting some parts of the code of ogx_menu.css (code of the label and code blocks when "maximized" exist) and ogx_left-sidebar.css in the section of -Nuevos margenes Botón menú- when "maximized" exist", being careful with brackets "{ }".

I made a fast edit to do that: ogx_menu.css : https://pastebin.com/B60xnRcn ogx_left-sidebar.css : https://pastebin.com/yFvwfdwt

matt1432 commented 10 months ago

That's great! Fixes my issue of it not being pretty, thank you. However my other issue was that since it puts the menu outside the window, there are some menus I can't access. Since my window focus changes with where my mouse is, i cannot click any buttons that go outside firefox. For example:

image

image

Godiesc commented 10 months ago

imagen

that is a OS problem, or your config of your mouse "focus", I can't do anything for that. The solution could be not move the "unified extension button" to the left.

matt1432 commented 10 months ago

Since I really want the extension button on the left I tried something and wanted your opinion on if it was a good idea or not:

image

image

By setting this margin-inline to -505px it works. I don't know if that would break anything else though

Godiesc commented 10 months ago

you can see what panels are you affecting with that, but if you don't see a problem so all is good, you solved. :)

imagen

matt1432 commented 10 months ago

This is what I've added to my custom css file to fix my issues:

#notification-popup {
  margin-top: -1px !important;
  margin-inline: -505px !important;
}

#customizationui-widget-panel {
  margin-top: -1px !important;
  margin-inline: -200px !important;
}

Thank you for your help with all my issues!