search

Godlander / objmc

A tool to bypass Minecraft Java Edition model limits by baking vertex data into texture.
MIT License
517 stars 43 forks source link

Fix fog_distance causing resourcepack to not load in vanilla 1.20.5 #64

Closed sheumais closed 5 months ago

sheumais commented 5 months ago

Hey, the most recent version causes a crash in vanilla 1.20.5

This is because the default particle vertex shader is looking for a function called "fog_distance" which is a vanilla function.

However, it receives a modified fog_distance function with a different signature, and this causes an error.

This pull request changes all references to "fog_distance" into "fog_distance_custom" and adds back the vanilla version of the function, under the original name.

I have tested my changes in release version 1.20.5, and it loads. This is corroborated by two other people in the discord.

image

Godlander commented 5 months ago

can we change it to follow vanilla instead? fog should be exactly vanilla behavior.

sheumais commented 5 months ago

can we change it to follow vanilla instead? fog should be exactly vanilla behavior.

Done.