exception for drum tab/guitar tab should be handled properly

Godley / MuseParse

Repository for a python music parser. This works with MusicXML as the input format which forms a tree of objects in memory representing the piece. This can be optionally outputted to lilypond which produces a PDF, or perused for your own uses.

MIT License

7 stars 2 forks source link

exception for drum tab/guitar tab should be handled properly #21

Open Godley opened 9 years ago

Godley commented 9 years ago

Issue by Godley Friday Mar 06, 2015 at 13:09 GMT Originally opened as https://github.com/Godley/FYP/issues/159

current system means ActorPreludeSample completely tips over. What we should do is:

catch the exception/don't throw it
delete the offending part and put it's part id onto a list of parts that have been ignored
continue loading (but skip out that part)
at the end, raise a warning for the GUI to read that tells the gui that this part has been ignored, which then tells the user but still lets them look at the music.

Godley commented 9 years ago

Comment by Godley Friday Mar 06, 2015 at 13:58 GMT

an optimised upgrade to this would be to recognise this problem when parsing the metadata: that way we could a) inform the user before we begin parsing that that part won't appear in the list of parts because we can't handle it, and ask if they want to continue b) cut out an unnecessary check which we would already know the result of from parsing the information

Godley commented 9 years ago

Comment by Godley Monday Mar 09, 2015 at 16:57 GMT

actually this isn't fixed: we need to push the info onto some kind of warning message queue rather than raise an exception, but for now this will do until I get to working on the GUI/meta parser