search

Godley / Music-Library

Repo for all FYP work, including meeting logs, implementation, report and any other necessary documents. Will be a mix of tex, python, word and pdf documents
GNU General Public License v2.0
5 stars 3 forks source link

Refreshing collection when nothing in collection causes error #326

Open DannyBrown-xx opened 8 years ago

DannyBrown-xx commented 8 years ago

If you don't have anything in your collection, selecting File > Refresh collection causes a long wait followed by this error box.

screen shot 2015-12-29 at 22 51 07

In addition, this error could be better formatted for reading purposes.

Godley commented 8 years ago

Having looked into this again I've reasoned why this happens. What it's doing is pulling down a lot of XML from the interwebs, from sources like MuseScore, so that you can search in the search box and it'll pull results out of the model for online sources, then deleting the XML. Apparently, sometimes that XML isn't valid. I turned off validation originally because it was so ridiculously slow, but once all that's moved to another thread as in issue #320 I should probably put back validation for online sources.

I'm in debate whether the debug output should be hidden from the user or not because it's only really useful info for me, so maybe I should upload it to a remote debug service?