search

Godofbrowser / vuejs-dialog

A lightweight, promise based alert, prompt and confirm dialog
MIT License
351 stars 111 forks source link

Enter/Return key on verification text reload the page #17

Closed IMPMAC closed 6 years ago

IMPMAC commented 6 years ago

If you go to the demo, scroll to the "Hard confirm - verification text required" button and click.

Then click in the verification box, press enter or return on the keyboard, it submits the form and refreshes the page.

I expect it to ignore the form submit

Godofbrowser commented 6 years ago

Obviously, that is a bug. Thanks! fixing immediately...

IMPMAC commented 6 years ago

@Godofbrowser Thanks, I guess Ill be notified by Github when its pushed.

Keep up the good work!

Godofbrowser commented 6 years ago

@IMPMAC 1 new github notification 😀

Godofbrowser commented 6 years ago

Closing as the issue has been fixed.

IMPMAC commented 6 years ago

@Godofbrowser Yep, I can confirm in my testing that this issue has been fixed.

IMPMAC commented 6 years ago

Hi, somewhat related to this, could you add a parameter to disable Chromes autocomplete feature. I believe its autocomplete="false" to add to the input field.

This is because once you type in "reset" the first time, the second time, it will automatically give you a drop down with the word "reset' inside.

Thanks.

Godofbrowser commented 6 years ago

Its very necessary. Would fix that asap. Thanks.

On Feb 22, 2018 5:11 PM, "Ismail Patel" notifications@github.com wrote:

Hi, somewhat related to this, could you add a parameter to disable Chromes autocomplete feature. I believe its autocomplete="false" to add to the input field.

This is because once you type in "reset" the first time, the second time, it will automatically give you a drop down with the word "reset' inside.

Thanks.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Godofbrowser/vuejs-dialog/issues/17#issuecomment-367731506, or mute the thread https://github.com/notifications/unsubscribe-auth/ATZTjwqR1xaNOKgBcAuoyoWHHc_x_cmVks5tXZG0gaJpZM4RhM-3 .