search

Godofbrowser / vuejs-dialog

A lightweight, promise based alert, prompt and confirm dialog
MIT License
351 stars 111 forks source link

remove external reference to google font css #20

Closed slano closed 6 years ago

slano commented 6 years ago

Hello Godofbrowser,

first of all thanks for a great vue package, I find it very useful.

One future request to get rid of a minor annoyance. Is there any chance to remove google fonts api import in the javascript?

"@import url(https://fonts.googleapis.com/css?family=Noto+Sans:400,700);"

If I use vuejs-dialog bundled in my project's single app.js, and try to export a page of such project into .pdf using wkhtmltopdf for example the export fails without a connection to the internet, as wkhtmltopdf is not able to fetch the data from googleapis.com.

Thanks!

Godofbrowser commented 6 years ago

Thanks for the commendation @slano , i'm looking at the best possible solution to this issue. Meanwhile, suggestions are welcomed.

marekfilip commented 6 years ago

@Godofbrowser thanks for sharing your package. It it very helpful indeed 👍

I would be very pleased for this feature as well, it would remove problem with "Leverage browser caching" in Google PageSpeed Insights. It is known that Google Fonts cache is set to 24 hours.

Godofbrowser commented 6 years ago

External fonts removed @slano @marekfilip . Plugin will inherit the document's font.

marekfilip commented 6 years ago

@Godofbrowser thanks for really fast feature! That fixed my problem.

Godofbrowser commented 6 years ago

You're welcome.

On Mar 6, 2018 8:07 PM, "Filip Marek" notifications@github.com wrote:

@Godofbrowser https://github.com/godofbrowser thanks for really fast feature! That fixed my problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Godofbrowser/vuejs-dialog/issues/20#issuecomment-370892285, or mute the thread https://github.com/notifications/unsubscribe-auth/ATZTjz5V3Bf9XBQ-nmCtLULOBQm_IWJMks5tbt5dgaJpZM4STOfM .